Added override functionality for github issues links #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbbeeston
reviewed
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to ticket #935.
For now it's only set up with the Outcome library. The original ticket mentioned asio works the same way but looking at the Asio git repo it looks like they're using github issues.
There was discussion in that thread of looking at the repo and checking if they're a fork or issues are closed. Given there's no reliably consistent programmatic way to account for each edge case those would introduce and we'd need the overriding url anyway, it's simpler to just check the override map for an existing key as this PR does.
Happy to change it if anyone feels that's worth the effort and can map out all the edge cases.