Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make apt-get calls consistent #253

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make apt-get calls consistent #253

wants to merge 2 commits into from

Conversation

Flamefire
Copy link
Collaborator

  • Don't install packages implicitely
  • Make quiet(er)
  • Use retries

@Flamefire
Make apt-get calls consistent
e6bce9d 
- Don't install packages implicitely
- Make quiet(er)
- Use retries
@Flamefire Flamefire marked this pull request as draft December 19, 2024 13:08
@Flamefire Flamefire marked this pull request as ready for review December 19, 2024 13:18
@Flamefire
Install gcc-multilib explicitely
da537f2 
Required as this is not automatically pulled in anymore
@Flamefire Flamefire closed this Dec 19, 2024
@Flamefire Flamefire reopened this Dec 19, 2024
@Flamefire Flamefire requested a review from sdarwin December 19, 2024 13:49
@Flamefire
Copy link
Collaborator Author

@sdarwin I've seen some Boost repos already using this, so I figured it makes sense to make it universally used. Can you see any potential issues with this?

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (58d2450) to head (da537f2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #253   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           22        22           
  Branches        10        10           
=========================================
  Hits            22        22

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d2450...da537f2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdarwin sdarwin Awaiting requested review from sdarwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Flamefire