build type에 따른 httpinterceptor Logging #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2taezeat
changed the title
youlalala
reviewed
Nov 15, 2023
| val httpLoggingInterceptor = HttpLoggingInterceptor().apply { | ||
| level = if (BuildConfig.DEBUG) HttpLoggingInterceptor.Level.BODY else HttpLoggingInterceptor.Level.NONE | ||
| } | ||
|
|
There was a problem hiding this comment.
Timber 를 적용했던 이유가 httplogging 할 때, debug 일때만 Log 찍히게 하기 위해서 적용했었는데, 지금 처럼 따로 if 문으로 적용해줄거면 Timber 를 사용하는 이유가 없어지는 것 같습니당! https://github.com/square/okhttp/tree/master/okhttp-logging-interceptor 처럼 timber 로 log를 찍게 해야할 것 같습니다 ~
HamBP
approved these changes
Nov 15, 2023
| @Module | ||
| @InstallIn(SingletonComponent::class) | ||
| object NetworkModule { | ||
|
|
||
| @Singleton | ||
| @Provides | ||
| fun provideOkHttpClient(): OkHttpClient { | ||
| val httpLoggingInterceptor = HttpLoggingInterceptor() | ||
| val logger = HttpLoggingInterceptor.Logger { message -> Timber.tag("okHttp").d(message) } |
There was a problem hiding this comment.
String.format(
getString(R.string.timber_log_format),
super.createStackElementTag(element),
element.lineNumber,
)
tag("okHttp") 메서드 호출하는 부분과 위 코드 블럭 중 하나는 무시될 거 같아
youlalala
reviewed
Nov 15, 2023
android/core/data/build.gradle.kts
Outdated
| @@ -35,4 +40,6 @@ dependencies { | |||
| implementation(libs.okhttp.logging.interceptor) | |||
| implementation(libs.kotlinx.serialization.json) | |||
| implementation(libs.kotlinx.serialization.converter) | |||
| implementation(libs.timber) | |||
There was a problem hiding this comment.
아까 PR에 feature plugin 에 timber 넣은것 같은데 android library plugin 에 timber 넣고 기존 feature plugin 에 timber 지우면 이 디펜던시는 없어도 될것같아ㅏ@@@
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
#76 (comment)
실험 해본 결과
timber_log_format도 약간 수정했습니다 ('/' 가 있으면 좀 다르게 출력되어 뺐습니다.)