Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

플레이리스트 상세 UI #269

Merged
merged 8 commits into from
Dec 6, 2023
Merged

플레이리스트 상세 UI #269

merged 8 commits into from
Dec 6, 2023

Conversation

youlalala
Copy link
Member

@youlalala youlalala commented Dec 4, 2023 •
edited
Loading

Issue

Overview

  • PlaylistUiModel 생성
  • 플레이리스트 배경 이미지 그라데이션 적용
  • status bar 투명하게 하고, 영역 확장
    • 화면 영역 넓히기 (공식문서),
    • status bar 를 확장해서 사용할 경우 -> app bar layout 에 fitsSystemWindow 속성을 true
      확장하지 않는 경우 -> root layout 에 fitsSystemWindow 속성을 true
      로 하여 UI가 가려지지 않도록 설정 공식문서

Screenshot

imageimage

@youlalala youlalala added ✨ feat 기능 개발 🤖 android android labels Dec 4, 2023
@youlalala youlalala self-assigned this Dec 4, 2023
@youlalala youlalala added this to the ⏯️ playlist milestone Dec 4, 2023
@youlalala youlalala linked an issue Dec 4, 2023 that may be closed by this pull request
플레이리스트 상세 UI #255
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited
Loading

Test Results

6 tests   6 ✔️  1s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 785cb73.

♻️ This comment has been updated with latest results.

@youlalala youlalala force-pushed the android/feature/255 branch from 82f5da3 to d093bb2 Compare December 5, 2023 07:32
@youlalala youlalala force-pushed the android/feature/255 branch from 9d10fbc to 677240d Compare December 5, 2023 07:34
2taezeat
2taezeat approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@2taezeat 2taezeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ , statusbar 관련해서 짧게 문서화 해도 좋을 거 같아요~

HamBP
HamBP approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@HamBP HamBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋져요~

@youlalala youlalala merged commit 8df8cd4 into develop Dec 6, 2023
2 checks passed
@youlalala youlalala deleted the android/feature/255 branch December 6, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2taezeat 2taezeat 2taezeat approved these changes

@HamBP HamBP HamBP approved these changes

Assignees

@youlalala youlalala

Labels
🤖 android android ✨ feat 기능 개발
Projects
None yet
Milestone
⏯️ playlist
Development

Successfully merging this pull request may close these issues.

플레이리스트 상세 UI
3 participants
@youlalala @HamBP @2taezeat