Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fail) 공통으로 사용되는 MusicAdapter, UI #144

Closed
wants to merge 17 commits into from
Closed

(fail) 공통으로 사용되는 MusicAdapter, UI #144

wants to merge 17 commits into from

Conversation

2taezeat
Copy link
Collaborator

@2taezeat 2taezeat commented Nov 21, 2023 •
edited
Loading

내용 무

HamBP and others added 17 commits November 21, 2023 16:59
@HamBP @2taezeat
feat : kotest CI 환경 설정
ef88713
@HamBP @2taezeat
chore : ci 파일, test task를 실행하도록 변경
b6327e9
@2taezeat
chore : TestConfig -> KoTestConfig 네이밍 변경 및 상위 패키지로 이동
d248557
@2taezeat
chore : root gradle 에 tasks 추가
fee423a
@2taezeat
test : gradle 확인용 SampleTest 추가
c1d0611
@2taezeat
chore: android-ci, run test 명령 변경
c89eb96
@2taezeat
test : SampleTest 변경
3cf1a3c
@2taezeat
test : SampleTest 모두 통과하게 수정
64e2ec8
@2taezeat
chore : test Task 카멜 케이스로 변경
e206456
@2taezeat
chore: android-ci, run test 변경
e2dd224
@2taezeat
chore : ui -> domain 의존성 추가
eaf7d05
@2taezeat
feat : item_music_vertical UI
a1233a6
@2taezeat
chore : 불 필요한 SampleTest 삭제
54b7762
@2taezeat
feat : MusicAdapter 로 Vertical, Horizontal 통합
8ed09ef
@2taezeat
feat : submitData BindingAdapter 추가
7f27e7e
@2taezeat
feat : dummy data binding 및 UI 개선
caa872d
@2taezeat
refactor : else 문 대신, 명확히 타입 명시
21825ff
@2taezeat 2taezeat added ✨ feat 기능 개발 🤖 android android labels Nov 21, 2023
@2taezeat 2taezeat added this to the 👋 my milestone Nov 21, 2023
@2taezeat 2taezeat self-assigned this Nov 21, 2023
@2taezeat 2taezeat linked an issue Nov 21, 2023 that may be closed by this pull request
VerticalMusicAdapter 생성 #121
Closed
@2taezeat 2taezeat changed the title Android/feature/121 공통으로 사용되는 MusicAdapter UI Nov 21, 2023
@2taezeat 2taezeat changed the title 공통으로 사용되는 MusicAdapter UI 공통으로 사용되는 MusicAdapter, UI Nov 21, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2023 •
edited
Loading

Test Results

7 tests   7 ✔️  1s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 21825ff.

♻️ This comment has been updated with latest results.

@HamBP
Copy link
Member

HamBP commented Nov 21, 2023 •
edited
Loading

지난 PR의 커밋이 섞여 있어
스쿼시 머지 하거나 리베이스가 잘못 되면 이런 문제가 생길 수 있을 듯. (같은 커밋인데 해시가 다름)
커밋이 몇 개 안 되니 체리픽으로 커밋 내역을 정리하는 게 깔끔할 거 같아

@2taezeat 2taezeat closed this Nov 21, 2023
@2taezeat 2taezeat deleted the android/feature/121 branch November 21, 2023 14:09
@2taezeat 2taezeat changed the title 공통으로 사용되는 MusicAdapter, UI (오류) 공통으로 사용되는 MusicAdapter, UI Nov 21, 2023
@2taezeat 2taezeat changed the title (오류) 공통으로 사용되는 MusicAdapter, UI (fail) 공통으로 사용되는 MusicAdapter, UI Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youlalala youlalala Awaiting requested review from youlalala youlalala is a code owner

@HamBP HamBP Awaiting requested review from HamBP HamBP is a code owner

Assignees

@2taezeat 2taezeat

Labels
🤖 android android ✨ feat 기능 개발
Projects
None yet
Milestone
👋 my
Development

Successfully merging this pull request may close these issues.

VerticalMusicAdapter 생성
2 participants
@2taezeat @HamBP