Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotest CI result 업로드 #137

Merged
merged 10 commits into from
Nov 21, 2023
Merged

Kotest CI result 업로드 #137

merged 10 commits into from
Nov 21, 2023

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented Nov 20, 2023

Issue

Overview

  • Kotest에서도 단위 테스트 보고서를 업로드하도록 설정

  • TestConfig path를 적절한 경로로 변경

  • project 수준의 build.gradle.kts이 아닌 모듈에다가 task를 설정했어야 했다.

  • testDebugUnitTest 로는 Domain 모듈을 인식 할 수 없으므로, root gradle에 domain:test 하는 Task 추가

@HamBP HamBP added 🚀 CI / CD CI / CD 🤖 android android labels Nov 20, 2023
@HamBP HamBP added this to the 🔧 etc milestone Nov 20, 2023
@HamBP HamBP self-assigned this Nov 20, 2023
Copy link

github-actions bot commented Nov 20, 2023

Test Results

7 tests   7 ✔️  0s ⏱️
2 suites  0 💤
2 files    0

Results for commit 0d45f27.

♻️ This comment has been updated with latest results.

@2taezeat 2taezeat self-assigned this Nov 21, 2023
@2taezeat 2taezeat added 🔎 test Testing 🧦 chore Chore and removed 🧦 chore Chore labels Nov 21, 2023
@2taezeat 2taezeat changed the title feat : kotest CI 환경 설정 Kotest CI result 업로드 Nov 21, 2023
Copy link
Collaborator

@2taezeat 2taezeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

}
systemProperty("gradle.build.dir", project.buildDir)

tasks.register<Exec>("domain-unit-test") {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존의 다른 task의 이름이 testDebugUnitTest여서 카멜 케이스로 맞추는 게 어떨까 싶어!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영하겠습니다~


tasks.register<Exec>("debug-unit-test") {
dependsOn("domain-unit-test")
commandLine = listOf("gradle", "testDebugUnitTest")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 혹시 domain의 test만 돌아가지 않을까?
:core:domain 위치에서 testDebugUnitTest를 실행하면 부모의 testDebugUnitTest는 안 돌아갈 거 같아서!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUILD SUCCESSFUL in 53s
167 actionable tasks: 162 executed, 5 up-to-date

기존에 testUnitDebugTest 와 동일하게 다른 Task test도 돌아가는거 확인했습니다~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 여기가 루트구나

Copy link
Member

@youlalala youlalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample 코드만 지우고 머지하면 될 것 같습니당!! 정말 수고 많았어용 👏🏻

@2taezeat
Copy link
Collaborator

2taezeat commented Nov 21, 2023

다른 브랜치에서 SampleTest 삭제를 이미 해버려서, 지금 Merge 하겠습니다~

@2taezeat 2taezeat merged commit 2336024 into develop Nov 21, 2023
2 checks passed
@2taezeat 2taezeat linked an issue Nov 22, 2023 that may be closed by this pull request
@HamBP HamBP deleted the android/feature/118 branch November 22, 2023 01:54
@HamBP HamBP modified the milestones: 🔧 etc, 🦾 CI/CD Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotest CI 환경 설정
3 participants