닉네임 유효성 검사 #117
Merged
닉네임 유효성 검사 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
HamBP
commented
Nov 19, 2023
| import io.kotest.matchers.shouldBe | ||
|
|
||
| class NicknameValidationUseCaseTest : BehaviorSpec() { | ||
| private val nicknameValidationUseCase = NicknameValidationUseCase() |
There was a problem hiding this comment.
ViewModel을 테스트하는 거라면 viewModel 대신 sut라는 변수명을 사용하는 게 좋을 것 같아.
nicknameValidationUseCase도 원래는 sut라는 이름으로 지었지만, sut("닉네임")이라는 코드의 가독성이 떨어지는 것 같아서 usecase 이름을 그대로 사용했어
youlalala
approved these changes
Nov 20, 2023
2taezeat
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
TestConfig Class가 하는 일에 대해서 설명 부탁드립니다~ ( comment, slack, 또는 대면으로 하셔도 됩니다. )
There was a problem hiding this comment.
https://kotest.io/docs/extensions/junit_xml.html
이 부분을 적용하기 위한 코드인데, 실제로 적용에 성공하진 못 했어요 ㅠㅠ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
Screenshot
To Reviewers
CI 테스트 관련 참고 자료
https://kotest.io/docs/extensions/junit_xml.html
https://github.com/EnricoMi/publish-unit-test-result-action