시나리오 기반 부하테스트 적용 #4
Open
+89
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoonseo-han
requested review from
rdyjun,
Kontae and
chaeryeon823
as code owners
Kontae
approved these changes
Jan 16, 2025
Comment on lines
+54
to
+55
| "artillery": "^2.0.22", | ||
| "artillery-engine-socketio-v3": "^1.2.0", |
There was a problem hiding this comment.
서버 폴더의 package.json에도 동일하게 설치가 되었네 두 번 설치한건가?
일단 깃에선 취소해야할 것 같습니다
Comment on lines
+22
to
+23
| afterResponse: 'processM3U8' |
There was a problem hiding this comment.
artillery에서 일반 js 함수를 불러올 수 있다니... 따봉
Comment on lines
+2
to
+3
| target: 'http://localhost:3000' | ||
| processor: './processor.js' |
rdyjun
approved these changes
Jan 16, 2025
| async function processM3U8(requestSpec, response, context, ee) { | ||
| debug('Starting M3U8 processing'); | ||
| try { | ||
| if (!response || !response.body) { |
There was a problem hiding this comment.
Optional Chaining 을 피드백 하려다 js 파일인 걸 보고 납득!
|
|
||
| lines.forEach((line) => { | ||
| if ( | ||
| line.includes('/api/music/') && |
There was a problem hiding this comment.
정규식을 쓰면 더 간단하게 해결될 것 같음!
물론 이 방식이 더 직관적인 것은 맞습니다~
| - think: 30 |
There was a problem hiding this comment.
think가 sleep 같은 기능을 하는 것으로 알고 있는데, 마지막에 think를 사용한 이유가 궁금합니다~
Comment on lines
+22
to
+23
| afterResponse: 'processM3U8' |
There was a problem hiding this comment.
artillery에서 일반 js 함수를 불러올 수 있다니... 따봉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋개요
m3u8 동적 요청 및 이후 ts 파일 요청 시나리오에 기반한 부하테스트 진행
🕰️예상 리뷰시간
5분
📢상세내용
💥특이사항