-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: preview 수정 및 state Hoisting 적용 #197
base: refactor-state-hoisting
Are you sure you want to change the base?
Changes from 20 commits
2dd43ad
841361a
e3fea50
6a5d795
87e723a
ad80fe5
265147d
2936826
0c51c35
062d882
5ab399c
69072de
3c61d09
2904e28
f5692d0
440830c
46f0778
e3fb208
8ea1a00
6f87526
1414bfc
a9bf2c7
db1b518
7615e0c
f80ab93
65aac5d
2f12d48
4570e47
3f73f6d
d4a8ef6
1a8ab39
4e9abb1
bac024e
2bcc528
812f957
2ed58e1
eea0fa4
3f22a0e
3a7ffe2
a2bd89f
0106bcd
5b896a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
package kr.boostcamp_2024.course.quiz.component | ||
|
||
import android.content.res.Configuration.UI_MODE_NIGHT_YES | ||
import android.content.res.Configuration.UI_MODE_TYPE_NORMAL | ||
import androidx.compose.foundation.background | ||
import androidx.compose.foundation.layout.Box | ||
import androidx.compose.foundation.layout.defaultMinSize | ||
|
@@ -14,7 +16,6 @@ import androidx.compose.ui.Modifier | |
import androidx.compose.ui.draw.clip | ||
import androidx.compose.ui.text.style.TextAlign | ||
import androidx.compose.ui.tooling.preview.Preview | ||
import androidx.compose.ui.tooling.preview.PreviewLightDark | ||
import androidx.compose.ui.unit.dp | ||
|
||
@OptIn(ExperimentalMaterial3Api::class) | ||
|
@@ -50,9 +51,9 @@ internal fun QuizSolveTimeSlider( | |
} | ||
|
||
@Preview(showBackground = true, locale = "ko") | ||
@PreviewLightDark | ||
@Preview(uiMode = UI_MODE_NIGHT_YES or UI_MODE_TYPE_NORMAL, locale = "ko") | ||
@Composable | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 해당 부분은 @PreviewKoLightDark가 적용되어 있지 않네요! 다른 부분도 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
fun QuizSolveTimeSliderPreview() { | ||
private fun QuizSolveTimeSliderPreview() { | ||
QuizSolveTimeSlider( | ||
value = 0f, | ||
steps = 10, | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
접근 제한자를 붙이지 않은 이유가 따로 있으실까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아니 스크린에 제한자를 다 빼먹었군요... 요번주에 혼이 나가있어서 실수가 많네요 수정하겠습니다!