fix : status 반환 잘못된거 수정

insert 부분에서 status 가 잘 못 반환되는 문제를 수정했습니다. #72
boostcamp-2020 · Nov 6, 2020 · 0328aef · 0328aef
1 parent fc5ffe6
commit 0328aef
Show file tree

Hide file tree

Showing 8 changed files with 313 additions and 315 deletions.
diff --git a/BE/package-lock.json b/BE/package-lock.json
diff --git a/BE/src/controllers/milestone.ts b/BE/src/controllers/milestone.ts
@@ -18,7 +18,6 @@ const add = async (req: Request, res: Response): Promise<Response> => {
     name: req.body.name,
     description: req.body.description,
     due_date: req.body.due_date,
-    state: true,
     created_at: new Date(),
   };
   const result = await MilestoneModel.add(milestone);

diff --git a/BE/src/interfaces/milestone.ts b/BE/src/interfaces/milestone.ts
@@ -4,6 +4,5 @@ export interface Milestone {
   name: string;
   description: string;
   due_date: Date | null;
-  state: boolean;
   created_at: Date;
 }
diff --git a/BE/src/models/assignee.ts b/BE/src/models/assignee.ts
@@ -32,7 +32,7 @@ class AssigneeModel extends Model {
   async add(pData: Assignee): Promise<number> {
     try {
       this.data = await super.insert(pData, this.tableName);
-      return this.data ? this.data : HTTPCODE.FAIL;
+      return this.data ? HTTPCODE.SUCCESS : HTTPCODE.FAIL;
     } catch {
       return HTTPCODE.SERVER_ERR;
     }

diff --git a/BE/src/models/comment.ts b/BE/src/models/comment.ts
@@ -29,7 +29,7 @@ class CommentModel extends Model {
   async add(pData: Comment): Promise<any> {
     try {
       this.data = await super.insert(pData, this.tableName);
-      return this.data ? this.data : HTTPCODE.FAIL;
+      return this.data ? HTTPCODE.SUCCESS : HTTPCODE.FAIL;
     } catch {
       return HTTPCODE.SERVER_ERR;
     }

diff --git a/BE/src/models/event.ts b/BE/src/models/event.ts
@@ -25,7 +25,7 @@ class EventModel extends Model {
   async add(pData: Event): Promise<number> {
     try {
       this.data = await super.insert(pData, this.tableName);
-      return this.data ? this.data : HTTPCODE.FAIL;
+      return this.data ? HTTPCODE.SUCCESS : HTTPCODE.FAIL;
     } catch {
       return HTTPCODE.SERVER_ERR;
     }

diff --git a/BE/src/models/issue.ts b/BE/src/models/issue.ts
@@ -37,7 +37,7 @@ class IssueModel extends Model {
   async add(pData: Issue): Promise<number> {
     try {
       this.data = await super.insert(pData, this.tableName);
-      return this.data ? this.data : HTTPCODE.FAIL;
+      return this.data ? HTTPCODE.SUCCESS : HTTPCODE.FAIL;
     } catch {
       return HTTPCODE.SERVER_ERR;
     }

diff --git a/BE/src/models/label.ts b/BE/src/models/label.ts
@@ -25,7 +25,7 @@ class LabelModel extends Model {
   async add(pData: Label): Promise<number> {
     try {
       this.data = await super.insert<Label>(pData, `${this.tableName}`);
-      return this.data ? this.data : HTTPCODE.FAIL;
+      return this.data ? HTTPCODE.SUCCESS : HTTPCODE.FAIL;
     } catch {
       return HTTPCODE.SERVER_ERR;
     }