Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "last modified" date for folders based on their contents. #689

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

dcavins
Copy link
Collaborator

@dcavins dcavins commented May 4, 2021

Update the containing folders' last_modified date when docs are updated. See #688.

@dcavins dcavins closed this May 4, 2021
@dcavins dcavins reopened this May 4, 2021
@dcavins dcavins changed the base branch from master to 2.2.x May 4, 2021 18:42
@dcavins dcavins requested a review from boonebgorges July 20, 2021 16:22
@boonebgorges
Copy link
Owner

I like these changes - if they test OK on your end, feel free to merge into 2.2.x 🚢

@dcavins dcavins merged commit e9d59c0 into boonebgorges:2.2.x Jul 20, 2021
@dcavins
Copy link
Collaborator Author

dcavins commented Jul 20, 2021

Thanks, Boone!

@dcavins dcavins deleted the folder-modified-date branch July 20, 2021 18:54
@dcavins
Copy link
Collaborator Author

dcavins commented Jul 20, 2021

One thing I think I got backwards in this: I assumed that the folder sort order should be by name, because that's how they were ordered before. However, when you first visit the docs library with no "orderby" specified, the docs are sorted by modified date, and the "sort" indicator appears above the "Last Edited" column.

Do you think the default folder sort order should change from what it was and be by last modified? It would break the old behavior, but it would make the UI more consistent. Thanks!

@boonebgorges
Copy link
Owner

IMO, it feels natural for the default sort order of Docs to be by post_modified, but for folder sorting to be by name. Does this seem right to you? If so, can you figure out a way to put a toggle in the interface for listing folders so that we could take advantage of the 'modified' sort, but only as a secondary option rather than the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants