Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java17): Java 17 special case #2559

Merged
merged 5 commits into from
Dec 22, 2023
Merged

feat(java17): Java 17 special case #2559

merged 5 commits into from
Dec 22, 2023

Conversation

rbioteau
Copy link
Member

No description provided.

Copy link
Contributor

github-actions bot commented Dec 19, 2023

♻️ PR Preview fb5077d has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

Copy link
Contributor

📝 Check the pages that have been modified

In order to merge this pull request, you need to check your updates with the following url.

🔍 Updated pages

The following pages were updated, please ensure that the display is correct:

Copy link
Contributor

@vhemery vhemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still Java 11 mentioned as requirement...

@vhemery
Copy link
Contributor

vhemery commented Dec 21, 2023

@rbioteau
I'm not sure about the actual JRE requirement.
https://bonitasoft-bonita-doc-build_preview-pr-2559.surge.sh/bonita/latest/version-update/update-with-update-tool#_jre_requirements

Is it really JRE 11 "If targeting an update from Bonita 2021.2 or greater" ? Not "If targeting an update to Bonita 2021.2 or greater" ?
And I guess we could also already add the line about JRE 17.

Copy link
Contributor

@vhemery vhemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JRE requirements needs to be updated.

@vhemery
Copy link
Contributor

vhemery commented Dec 22, 2023

@rbioteau do my changes look good to you ?

@rbioteau rbioteau merged commit 4b5bed1 into 2024.1 Dec 22, 2023
3 checks passed
@rbioteau rbioteau deleted the feat/java17_update_tool branch December 22, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants