Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(properties): document how to configure Bonita with properties #2556

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

educhastenier
Copy link
Contributor

  • with Setup Tool
  • via Java Sysprops
  • via Env vars

* with Setup Tool
* via Java Sysprops
* via Env vars
Copy link
Contributor

github-actions bot commented Dec 13, 2023

🎊 PR Preview 21f46b7 has been successfully built and deployed to https://bonitasoft-bonita-doc-build_preview-pr-2556.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

Copy link
Contributor

github-actions bot commented Dec 13, 2023

📝 Check the pages that have been modified

In order to merge this pull request, you need to check your updates with the following url.

🔍 Updated pages

The following pages were updated, please ensure that the display is correct:

Copy link
Contributor

@vhemery vhemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the configuring-bonita-with-properties.adoc from the navigation menu.
It should be added in runtime-configuration-index and in runtime-nav.adoc

Also see suggestions inline.


Some properties cannot be changed via System Properties or Environment Variables:

* TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No TODO in the final doc site... 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in next commit

@vhemery
Copy link
Contributor

vhemery commented Dec 13, 2023

I can't find the configuring-bonita-with-properties.adoc from the navigation menu. It should be added in runtime-configuration-index and in runtime-nav.adoc

Also see suggestions inline.

Argh.. my most meaningfull comment was lost...
I was suggesting to use alternative presentation for:

@educhastenier
Copy link
Contributor Author

I can't find the configuring-bonita-with-properties.adoc from the navigation menu. It should be added in runtime-configuration-index and in runtime-nav.adoc
Also see suggestions inline.

Argh.. my most meaningfull comment was lost... I was suggesting to use alternative presentation for:

Feedbacks integrated.
Thx for the suggestions.

Copy link
Contributor

@vhemery vhemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me

@vhemery vhemery merged commit bb7a27d into 2023.2 Dec 14, 2023
3 checks passed
@vhemery vhemery deleted the feat/properties/document_bonita_properties branch December 14, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants