-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(properties): document how to configure Bonita with properties #2556
Conversation
educhastenier
commented
Dec 13, 2023
- with Setup Tool
- via Java Sysprops
- via Env vars
* with Setup Tool * via Java Sysprops * via Env vars
🎊 PR Preview 21f46b7 has been successfully built and deployed to https://bonitasoft-bonita-doc-build_preview-pr-2556.surge.sh 🕐 Build time: 0.01s 🤖 By surge-preview |
📝 Check the pages that have been modifiedIn order to merge this pull request, you need to check your updates with the following url. 🔍 Updated pagesThe following pages were updated, please ensure that the display is correct: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find the configuring-bonita-with-properties.adoc from the navigation menu.
It should be added in runtime-configuration-index and in runtime-nav.adoc
Also see suggestions inline.
|
||
Some properties cannot be changed via System Properties or Environment Variables: | ||
|
||
* TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No TODO in the final doc site... 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in next commit
Argh.. my most meaningfull comment was lost...
|
Feedbacks integrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me