Add ETH dump #1373
Merged
Add ETH dump #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err != nil { | ||
| panic(err) | ||
| } | ||
| err = os.WriteFile(os.Getenv("L2GETH_ETH_DUMP_PATH"), content, 0644) |
There was a problem hiding this comment.
It looks like this is overwriting the entire file each time a new address is seen. That seems inefficient, but I suppose it doesn't matter if the total dataset is small enough. I'll approve the overall PR, but if you do see performance issues then consider appending to a file one address at a time.
There was a problem hiding this comment.
Yes, if we change how the file is written, we'll need to make some changes in boba-chain-ops.
mmontour1306
approved these changes
Mar 26, 2024
jyellick
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Add associated issues, tickets, docs URL here.
Overview
Describe what your Pull Request is about in a few sentences.
Add ethdump
Changes
Describe your changes and implementation choices. More details make PRs easier to review.
Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.
The unit test is added