Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup CLI to use eyre + refactor patterns #4108

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Cleanup CLI to use eyre + refactor patterns #4108

merged 1 commit into from
Jan 7, 2025

Conversation

jedel1043
Copy link
Member

This should both make it easier to develop the CLI and also make it easier to add custom error messages in the future.

Closes #4085.

@jedel1043 jedel1043 added enhancement New feature or request cli Issues and PRs related to the Boa command line interface. labels Jan 5, 2025
@jedel1043 jedel1043 added this to the next-release milestone Jan 5, 2025
@jedel1043 jedel1043 requested a review from a team January 5, 2025 06:59
@jedel1043 jedel1043 mentioned this pull request Jan 5, 2025
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 43,947 43,947 0
Ignored 3,096 3,096 0
Failed 3,211 3,211 0
Panics 0 0 0
Conformance 87.45% 87.45% 0.00%

raskad
raskad reviewed Jan 5, 2025
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I just have one comment.

cli/src/main.rs Outdated Show resolved Hide resolved
@jedel1043 jedel1043 force-pushed the fix-referrer-path-cli branch from 155933c to c6e9f8e Compare January 5, 2025 17:22
@raskad raskad requested a review from a team January 5, 2025 17:26
@nekevss nekevss added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit c5f2c56 Jan 7, 2025
13 checks passed
@nekevss nekevss deleted the fix-referrer-path-cli branch January 7, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@raskad raskad raskad approved these changes

Assignees
No one assigned
Labels
cli Issues and PRs related to the Boa command line interface. enhancement New feature or request
Projects
None yet
Milestone
next-release
Development

Successfully merging this pull request may close these issues.

SimpleModuleLoader cannot resolve relative paths on the CLI
3 participants
@jedel1043 @raskad @nekevss