Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some clones and branches in hot PropertyDescriptor functions #4104

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Remove some clones and branches in hot PropertyDescriptor functions #4104

merged 1 commit into from
Dec 30, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented Dec 30, 2024

This Pull Request changes the following:

  • Avoid cloning values in PropertyDescriptor functions.
  • Avoid some matches in PropertyDescriptor functions.

@raskad raskad added performance Performance related changes and issues execution Issues or PRs related to code execution labels Dec 30, 2024
@raskad raskad added this to the next-release milestone Dec 30, 2024
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 43,947 43,947 0
Ignored 3,096 3,096 0
Failed 3,211 3,211 0
Panics 0 0 0
Conformance 87.45% 87.45% 0.00%

@raskad raskad requested a review from a team December 30, 2024 20:30
jasonwilliams
jasonwilliams approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedel1043 jedel1043 added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit 13344ce Dec 30, 2024
13 checks passed
@jedel1043 jedel1043 deleted the prop-desc-opt branch December 30, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams jasonwilliams approved these changes

Assignees
No one assigned
Labels
execution Issues or PRs related to code execution performance Performance related changes and issues
Projects
None yet
Milestone
next-release
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jasonwilliams @jedel1043