Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix very minor typo shift -> unshift #4097

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

albertleigh
Copy link
Contributor

This Pull Request fixes a very minor type in its rust jsArray api

It changes the following:

  • just rename shift into unshift in jsarray::unshfit

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you were talking about it nonchalantly, I thought it was a doc typo, but that's a very good bug catch! Thank you for the contribution!

@jedel1043 jedel1043 requested a review from a team December 26, 2024 15:58
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.75%. Comparing base (6ddc2b4) to head (fbfd57d).
Report is 327 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/object/builtins/jsarray.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4097      +/-   ##
==========================================
+ Coverage   47.24%   53.75%   +6.51%     
==========================================
  Files         476      485       +9     
  Lines       46892    48320    +1428     
==========================================
+ Hits        22154    25975    +3821     
+ Misses      24738    22345    -2393     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops lol nice catch! Thanks for the contribution!

@nekevss nekevss added this pull request to the merge queue Dec 26, 2024
Merged via the queue into boa-dev:main with commit 1af4494 Dec 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants