Skip to content

Commit

Permalink
Remove the feature flag for NaN boxing now that were closer in perf
Browse files Browse the repository at this point in the history
  • Loading branch information
hansl committed Jan 5, 2025
1 parent ca9f657 commit e29cedb
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 271 deletions.
1 change: 0 additions & 1 deletion cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ dhat = { workspace = true, optional = true }
[features]
default = ["boa_engine/annex-b", "boa_engine/experimental", "boa_engine/intl_bundled"]
dhat = ["dep:dhat"]
nan-box-jsvalue = ["boa_engine/nan-box-jsvalue"]

[target.x86_64-unknown-linux-gnu.dependencies]
jemallocator.workspace = true
Expand Down
1 change: 0 additions & 1 deletion core/engine/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ rust-version.workspace = true
profiler = ["boa_profiler/profiler"]
deser = ["boa_interner/serde", "boa_ast/serde"]
either = ["dep:either"]
nan-box-jsvalue = []

# Enables the `Intl` builtin object and bundles a default ICU4X data provider.
# Prefer this over `intl` if you just want to enable `Intl` without dealing with the
Expand Down
15 changes: 0 additions & 15 deletions core/engine/src/value/inner.rs
Original file line number Diff line number Diff line change
@@ -1,18 +1,3 @@
//! Module implementing the operations for the inner value of a `[super::JsValue]`.
//!
//! The `[InnerValue]` type is an opaque type that can be either an enum of possible
//! JavaScript value types, or a 64-bits float that represents a NaN-boxed JavaScript
//! value, depending on feature flags. By default, the behaviour is to use the
//! enumeration.
#[cfg(feature = "nan-box-jsvalue")]
mod nan_boxed;

#[cfg(feature = "nan-box-jsvalue")]
pub(crate) use nan_boxed::NanBoxedValue as InnerValue;

#[cfg(not(feature = "nan-box-jsvalue"))]
mod enum_value;

#[cfg(not(feature = "nan-box-jsvalue"))]
pub(crate) use enum_value::EnumBasedValue as InnerValue;
254 changes: 0 additions & 254 deletions core/engine/src/value/inner/enum_value.rs

This file was deleted.

0 comments on commit e29cedb

Please sign in to comment.