Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 #131

Merged
merged 23 commits into from
Feb 3, 2025
Merged

V5 #131

merged 23 commits into from
Feb 3, 2025

Conversation

bnomei
Copy link
Owner

@bnomei bnomei commented Feb 3, 2025

No description provided.

Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
Signed-off-by: Bruno Meilick <[email protected]>
@bnomei bnomei merged commit 99a5a70 into master Feb 3, 2025
2 of 5 checks passed
@bnomei bnomei deleted the v5 branch February 3, 2025 15:29
Copy link

what-the-diff bot commented Feb 3, 2025

PR Summary

  • Updated GitHub Actions workflows: The workflows have been tailored to trigger only when there are changes to PHP files and a specific lock file (composer.lock). This is a way to automate further tasks related specifically to PHP development.

  • Changed the Installation Command: The installation command used in workflow files has shifted from composer install to composer kirby, this may improve the efficiency of installation in some workflows.

  • Updated the Test Command: This change updates how testing is performed. Tests will now run with the command vendor/bin/pest --ci.

  • README Updates: The README now boasts new badges and descriptions. It also includes a new section to guide users on creating custom view buttons.

  • Updated Software Version and Dependencies: The version number has been increased in the project metadata (composer.json). The new version 5.0.0 is in sync with Kirby CMS 5. The module dependencies were also updated.

  • Updated the PHPStan Configuration: This change has the effect of ignoring a particular recurrent code error. This will help to maintain accuracy in the static analysis results.

  • Modified Janitor Component: Previously $store was used to check content changes. Now, this function is performed by $panel.

  • Added Notification Feature: The Janitor actions will now notify the users when requests are made. This enhances the user experience by giving the users real-time status updates about their requests.

  • Updated JavaScript and CSS: The JavaScript and CSS codes regarding the Janitor button's style and behavior have been updated. This reflects in the better visual presentation and function of the button.

  • Enhanced Documentation: Documentation for the REPL and debugging commands were added to the README. This assists users by providing more detail on how to use some of these advanced features.

  • Enhanced Button Configurations: The buttons section has been expanded in the blueprint file tests/site/blueprints/pages/default.yml including new janitor commands and their configurations. This allows for more functionalities with janitor buttons.

  • Label and Help Text Modification: The help text and the label for a janitor field have been edited in tests/site/blueprints/pages/default.yml.

  • Added a New Command: A new notify command has been introduced in the file tests/site/commands/notify.php. This command will generate random panel notifications, assisting users in testing functionalities.

  • Updated File Contents: The files InstalledVersions.php and installed.php have been edited to show the new version (5.0.0) for the bnomei/kirby3-janitor package.

  • Error Handling Refactoring: The error handling in the Symfony Finder classes is now refactored to use \sprintf for messages. This change will improve error message readability and debugging efficiency.

  • Removed Redundant File: The patch.php file has been removed from the codebase. This file previously housed functions to manipulate Kirby helpers.

  • Updated Test Text: The text in tests/content/home/default.en.txt has been updated from "sss" to "world". This change would reflect in the output.

  • Debug Lines Commented Out: The debugging lines related to janitor commands in tests/site/templates/default.php have been commented out. They were mainly useful during the process of development and testing, but they are not necessary in the production environment.

  • Enhanced Multiple Janitor Instances: In src/index.js, the viewButtons section has been improved by adding multiple janitor instances. These instances range from janitor_0 to janitor_9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant