Resolve issues w/ hardcoded proj4string in some ranges_* functions #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the failures mentioned in #32. I've updated the code in
BIEN_ranges_load_speciesand inBIEN_ranges_speciesto use..., p4s = sf::st_crs(4326)[[2]], ....instead of
..., p4s = "+init=epsg:4326",...The latter was causing some errors with calls to
CRS(), which were returningNA. I think it's probably because of an update toCRS()in thesppackage.I've had trouble running all of the tests to verify that everything works, but I can run individual tests related to these functions and they now produce the expected results.
Hope this is helpful - let me know if you have any questions/comments! And thanks for making BIEN!