Causes error on world gen without check #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+24
to
+25
| if (Main.dedServ) | ||
| return; |
There was a problem hiding this comment.
Remove this and instead override IsLoadingEnabled to return !Main.dedServ
There was a problem hiding this comment.
Remove this and instead override
IsLoadingEnabledto return!Main.dedServ
That's not overrided in the Edit class so I assumed the authors didn't want it this way.
There was a problem hiding this comment.
Why would Edit need to override it?
There was a problem hiding this comment.
So inheriting classes could implement it...?
There was a problem hiding this comment.
IsLoadingEnabled is a virtual method on ILoadable
Edit implements ILoadable, therefore IsLoadingEnabled is available to override in Edit and classes that inherit from Edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receive index out of bounds on world gen due to no dedicated server check on this.