Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

February 2024 NPM Security Vulnerabilities Resolution #350

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

ashin-bluehalo
Copy link
Contributor

This PR is to resolve security vulnerabilities.

Note that the Lerna package was updated from v6 => v8. As of Lerna v7, the bootstrap package management command was deprecated. We are now not utilizing Lerna's bootstrap command, and are now relying on 'yarn install' to install the dependencies for each sub-package in the project (see the new 'workspaces' field in package.json. More information can be found here).

Validation steps:

  1. yarn install
  2. yarn audit
  3. Ensure there are 0 vulnerabilities found
  4. yarn run test
  5. Ensure that all 12/12 test suites are passing

Coverage remains the same before and after changes. See below for specific coverage reports for each sub-package.

Coverage before changes:

Coverage after changes:

@reblace reblace merged commit 4b42c9d into master Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants