fix ethersdb.rs forking #2047
Merged
fix ethersdb.rs forking #2047
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthersDB::with_runtime and EthersDB::with_handle were added in v11 for reasons involving async. Unlike EthersDB::new, these two functions always fork the latest block (even when a historical block is specified). This commit fixes that.
rakita
approved these changes
Feb 4, 2025
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EthersDB::with_runtime and EthersDB::with_handle were added in v11 for reasons involving async. Unlike EthersDB::new, these two functions always fork the latest block (even when a historical block is specified). This commit fixes that.