Add i3/i4 models to multiroom support to resolve #118 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senorshaun
approved these changes
Sep 27, 2022
|
Is it possible to officially merge this to enable multi-room support for i3? The code change seems fine to me. |
|
Isn't the imprint mapping only added to the i3 and up? The changes seems to not take in to account the i2 and i1. |
This is correct. The i1/i2 models were launched after I made this change. I have updated the check to include only i3 and up models. |
|
@senorshaun are there any plans to merge this PR into the stable or beta versions any time soon? It resolves an issue I'm having with an i3 so I'm keen to see if this fixes multi-room for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i3/i4 models now have smart mapping: https://homesupport.irobot.com/s/article/64103
Tested on my i3 and it performs as expected.