Avoid stack overflow in native symbolification when debuginfod returns a file with MiniDebugInfo #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
+ Coverage 92.55% 93.05% +0.49%
==========================================
Files 91 94 +3
Lines 11304 11412 +108
Branches 1581 2089 +508
==========================================
+ Hits 10462 10619 +157
+ Misses 837 793 -44
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The patches had some minor conflicts that needed to be resolved in order to upgrade: - `elf_add` gained a new `struct elf_ppc64_opd_data *` parameter (which we're able to pass a null pointer for) - One of our diff hunks can be dropped because it was applied upstream The changes to `src/vendor/libbacktrace/` itself are all made automatically by the `regenerate_libbacktrace.sh` script. Signed-off-by: Matt Wozniski <[email protected]>
If looking up debug info by build id returns a file with MiniDebugInfo (the `.gnu_debugdata` section), libbacktrace will infinitely recurse, leading to a stack overflow unless the limit on the maximum number of open file descriptors is reached before the stack can overflow. Work around this by ignoring the MiniDebugInfo if we've already successfully loaded the debug info by its build id. Signed-off-by: Matt Wozniski <[email protected]>
See changelog for more details. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
fix_minidebuginfo_crash
branch
from
c0d7631 to
1938667
Compare
pablogsal
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #636