Change how we determine the repo_root in Gemfile.
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old way doesn't appear to be working when dependabot is parsing our `Gemfile`.
We're getting errors like:
```
Dependabot encountered the following error:
Bundler::Dsl::DSLError with message: [!] There was an error parsing `Gemfile`: Permission denied @ dir_s_mkdir - /log. Bundler cannot continue.
# from dependabot_tmp_dir/Gemfile:48
# -------------------------------------------
# # We create them here since `Gemfile` evaluation happens before anything else.
> ::FileUtils.mkdir_p("#{repo_root}/log")
# ::FileUtils.mkdir_p("#{repo_root}/tmp")
# -------------------------------------------
```
I think the `.git` directory may not be there when dependabot parses the `Gemfile`.
Checking for a different file at the root will hopefully fix this.
myronmarston
added a commit
that referenced
this pull request
Jan 1, 2025
My earlier attempts (e.g. #82) did not work. Using the `dry_run` script[^1], I've discovered that dependabot runs bundler commands in a temporary directory that only contains _some_ of the source controlled files (e.g. the `Gemfile`, `*.gemspec` files, etc). To be compatible with dependabot, our `Gemfile` cannot assume the presence of any files beyond these. [^1]: https://github.com/dependabot/dependabot-core/blob/v0.291.0/bin/dry-run.rb
myronmarston
added a commit
that referenced
this pull request
Jan 1, 2025
My earlier attempts (e.g. #82) did not work. Using the `dry_run` script[^1], I've discovered that dependabot runs bundler commands in a temporary directory that only contains _some_ of the source controlled files (e.g. the `Gemfile`, `*.gemspec` files, etc). To be compatible with dependabot, our `Gemfile` cannot assume the presence of any files beyond these. [^1]: https://github.com/dependabot/dependabot-core/blob/v0.291.0/bin/dry-run.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old way doesn't appear to be working when dependabot is parsing our
Gemfile. We're getting errors like:I think the
.gitdirectory may not be there when dependabot parses theGemfile. Checking for a different file at the root will hopefully fix this.