Fix our gem constraint maintenance tooling. #237
Merged
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It hasn't been working because the `bundle install` run by `update_gem_constraints` fails due to the bundle being in frozen deployment mode. (That mode is something that `setup_ruby` enables when using the bundler cache). I've fixed that issue by explicitly disabling the mode. In addition, I've fixed `update_gem_constraints` to fail if `bundle install` fails rather than silently ignoring the failure. Finally, I've bumped the bundler cache version as the old logic would put it into a corrupted state.
|
|
akumar1214
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It hasn't been working because the
bundle installrun byupdate_gem_constraintsfails due to the bundle being in frozen deployment mode. (That mode is something thatsetup_rubyenables when using the bundler cache).I've fixed that issue by explicitly disabling the mode. In addition, I've fixed
update_gem_constraintsto fail ifbundle installfails rather than silently ignoring the failure.Finally, I've bumped the bundler cache version as the old logic would put it into a corrupted state.