Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve our docker image. #220

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

myronmarston
Copy link
Collaborator

  • Fix the docker ignores. They weren't working at all; apparently .dockerignore has to be at the content root (which is our repository root). I've also streamlined the .dockerignore file itself.
  • Avoid log messages that say "fatal: not a git repository (or any of the parent directories): .git".
  • Avoid a docker networking warning1.

Footnotes

  1. WARN[0215] a network with name opensearch exists but was not created for project "docker_demo". Set external: true to use an existing network

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@myronmarston myronmarston force-pushed the myron/further-docker-improvements branch from fcaffde to 725d321 Compare February 24, 2025 03:03
- Fix the docker ignores. They weren't working at all; apparently `.dockerignore`
  has to be at the content root (which is our repository root). I've also streamlined
  the `.dockerignore` file itself.
- Avoid log messages that say "fatal: not a git repository (or any of the parent directories): .git".
- Avoid a docker networking warning[^1].

[^1]: WARN[0215] a network with name opensearch exists but was not created for project "docker_demo". Set `external: true` to use an existing network
@myronmarston myronmarston force-pushed the myron/further-docker-improvements branch from 725d321 to 9b328be Compare February 24, 2025 21:54
@myronmarston myronmarston merged commit 3f61376 into main Feb 24, 2025
18 of 19 checks passed
@myronmarston myronmarston deleted the myron/further-docker-improvements branch February 24, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants