Refactor: move where args are converted to their schema form. #163
+82
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This paves the way for further refactoring I'm working on.
Rather than building them in `GraphQLAdapter` when a resolver yields, build them in the resolver that need it. This paves the way for a larger refactoring I'm working on.
|
|
Previously, we did it in `GraphQLResolver#call`, which gets invoked as part of resolving _every_ GraphQL field at every level of the response structure. We don't want to convert args to their schema form if we're not going to do anything with the args so it's better to defer it until it's needed.
myronmarston
force-pushed
the
myron/improve-perf/move-arg-conversion
branch
from
e6dc7aa to
68bdca9
Compare
myronmarston
force-pushed
the
myron/improve-perf/move-build-query
branch
from
faa4890 to
1fdee74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we did it in
GraphQLResolver#call, which gets invoked as part of resolving every GraphQL field at every level of the response structure. We don't want to convert args to their schema form if we're not going to do anything with the args so it's better to defer it until it's needed.