Update project template: add TODO comments. #142
Merged
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
force-pushed
the
myron/project-template-todos
branch
from
b3c95e9 to
e7f1f26
Compare
|
|
This clearly labels all the things that need changes after the project template has been generated. I also updated the spec to use a `path` instead of a `git` source for the `Gemfile`. I was getting odd errors from the `git` source: ``` Git error: command `git fetch --force --quiet --no-tags --depth 1 -- file:///Users/myron/Development/elasticgraph refs/heads/project_template:refs/heads/project_template` in directory /Users/myron/.rvm/gems/ruby-3.3.4/cache/bundler/git/elasticgraph-3c5d4d4f32023ab2bbd274f7df56f75f91a0e70e has failed. Revision does not exist in the repository file:///Users/myron/Development/elasticgraph. Maybe you misspelled it? ``` I don't know why it's looking for a `project_template` revision. Using a `path` source avoids the problem and ensures that the running spec uses the local code for the other gems even if they have uncommitted changes.
myronmarston
force-pushed
the
myron/project-template-todos
branch
from
e7f1f26 to
c56b130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clearly labels all the things that need changes after the project template has been generated.
I also updated the spec to use a
pathinstead of agitsource for theGemfile. I was getting odd errors from thegitsource:I don't know why it's looking for a
project_templaterevision. Using apathsource avoids the problem and ensures that the running spec uses the local code for the other gems even if they have uncommitted changes.