Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify define_fake_data_batch_for. #138

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

myronmarston
Copy link
Collaborator

The old interface was odd; we passed the block an empty array
and it would be populated within the block. It's a simpler,
cleaner interface (no mutation!) to have the block return
the batch of data.

The old interface was odd; we passed the block an empty array
and it would be populated within the block. It's a simpler,
cleaner interface (no mutation!) to have the block return
the batch of data.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@BrianSigafoos-SQ BrianSigafoos-SQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from myron/detect-datastore to main February 4, 2025 15:56
@myronmarston myronmarston merged commit a073623 into main Feb 4, 2025
14 of 15 checks passed
@myronmarston myronmarston deleted the myron/simplify-define-fake-data-batch branch February 4, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants