Fix initial type of Index#routing_field_path.
#134
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
akumar1214
approved these changes
Feb 3, 2025
This is a followup on #94. For historical/vestigial reasons, we used to set `routing_field_path` to `[]` before immediately updating it to the `FieldPath` object for `id`. With our change in #114 to lazily set `routing_field_path`, it allowed the value of `[]` to persists beyond `initialize`. `[]` isn't a valid value according to the type; instead I've changed the type to allow `nil` which is a more natural value for this case.
myronmarston
force-pushed
the
myron/94-followups2
branch
from
57ae5f8 to
b8a81e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup on #94. For historical/vestigial reasons, we used to set
routing_field_pathto[]before immediately updating it to theFieldPathobject forid. With our change in #114 to lazily setrouting_field_path, it allowed the value of[]to persists beyondinitialize.[]isn't a valid value according to the type; instead I've changed the type to allownilwhich is a more natural value for this case.