Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rake tasks for elasticsearch when opensearch configured. #130

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

myronmarston
Copy link
Collaborator

...and vice versa. Previously we always expected the elasticsearch and opensearch management tasks, regardless of what backend was configured. In our new project template I had put code to disable the other datastore. But we can disable it automatically, which is simpler for the end user.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Base automatically changed from myron/fix-inaccurate-docs to main February 3, 2025 20:04
An error occurred while trying to automatically change base from myron/fix-inaccurate-docs to main February 3, 2025 20:04
@myronmarston myronmarston force-pushed the myron/detect-datastore branch from 52abfca to 9b8e260 Compare February 4, 2025 03:16
...and vice versa. Previously we always expected  the elasticsearch
and opensearch management tasks, regardless of what backend was configured.
In our new project template I had put code to disable the other datastore.
But we can disable it automatically, which is simpler for the end user.
@myronmarston myronmarston force-pushed the myron/detect-datastore branch from 9b8e260 to cc98336 Compare February 4, 2025 03:50
@myronmarston myronmarston marked this pull request as ready for review February 4, 2025 15:03
Copy link
Collaborator

@BrianSigafoos-SQ BrianSigafoos-SQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myronmarston myronmarston merged commit 9e0f203 into main Feb 4, 2025
18 of 19 checks passed
@myronmarston myronmarston deleted the myron/detect-datastore branch February 4, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants