Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIB-9440: fix for fixed number of parameters #1

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

jfederico
Copy link
Contributor

This solves the bug for the fixed number of parameters, but we may want to refactor the way the data is handled so instead of 3 disconnected arrays like this

{
"flexurl_eventtype":["2","1","2","2"],
"flexurl_paramname":["custom_name","another","global_param_new","new_more"],
"flexurl_paramvalue":["user.alternatename","activityinfo.name","courseinfo.idnumber","activityinfo.id"]
}

we have a distinct objcet per row like this

[
[{"flexurl_eventtype":2},{"flexurl_paramname":"custom_name"},{"flexurl_paramvalue":"user.alternatename"}],
[{"flexurl_eventtype":1},{"flexurl_paramname":"another"},{"flexurl_paramvalue":"activityinfo.name"}],
[{"flexurl_eventtype":2},{"flexurl_paramname":"global_param_new"},{"flexurl_paramvalue":"courseinfo.idnumber"}],
[{"flexurl_eventtype":2},{"flexurl_paramname":"new_more"},{"flexurl_paramvalue":"activityinfo.id"}],
]

of course this would lead to a bigger change as the logic for rendering the data would need to change

@jfederico jfederico merged commit bef5ee8 into blindsidenetworks-ps:master Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant