Allow raw data access on ResourceObject #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing large JSON responses, the repeated instantiation of objects makes this processing extremely slow. Allowing raw data access allows much faster reading of responses. These changes allow users to skip convenience methods when all they need is the data itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing large JSON responses, the repeated instantiation of objects makes this processing extremely slow. Allowing raw data access allows much faster reading of responses.
These changes allow users to skip convenience methods when all they need is the data itself.
We experienced a decrease of about 3000% in processing time when using raw data access. In our case we're using excon-hypermedia to "get to the data" by following links, but then we get to a pretty heavy endpoint where all we need is the data.