Skip to content

Commit

Permalink
moved some stuff around no idea why the 2nd value in needs isn't givi…
Browse files Browse the repository at this point in the history
…ng me a value but last job it does.. derp.
  • Loading branch information
Bioblaze committed Dec 19, 2024
1 parent 631e969 commit 5c1231a
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/build-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
needs: get-latest-sha
runs-on: windows-latest
outputs:
version: ${{ steps.validate.outputs.newVersion }}
version: ${{ needs.get-latest-sha.outputs.version_string }}
steps:
- name: Checkout repository
uses: actions/checkout@v3
Expand Down Expand Up @@ -106,9 +106,10 @@ jobs:
with:
name: blazium-anko-extension-vsix
path: dist/blazium-anko-extension-${{ needs.get-latest-sha.outputs.version_string }}.vsix
retention-days: 1

release:
needs: [ build, get-latest-sha ]
needs: build
runs-on: windows-latest
permissions:
contents: write # Grants write permissions for content operations
Expand All @@ -125,8 +126,8 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ needs.get-latest-sha.outputs.version_string }}
release_name: Blazium Anko Extension v${{ needs.get-latest-sha.outputs.version_string }}
tag_name: ${{ needs.build.outputs.version }}
release_name: Blazium Anko Extension v${{ needs.build.outputs.version }}
draft: false
prerelease: false

Expand All @@ -136,8 +137,8 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.createRelease.outputs.upload_url }}
asset_path: ${{ github.workspace }}/dist/blazium-anko-extension-${{ needs.get-latest-sha.outputs.version_string }}.vsix
asset_name: blazium-anko-extension-${{ needs.get-latest-sha.outputs.version_string }}.vsix
asset_path: ${{ github.workspace }}/dist/blazium-anko-extension-${{ needs.build.outputs.version }}.vsix
asset_name: blazium-anko-extension-${{ needs.build.outputs.version }}.vsix
asset_content_type: application/octet-stream


0 comments on commit 5c1231a

Please sign in to comment.