Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added threading to improve performance and a try/except on request #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LuanFranco98
Copy link

First of all i want to congratulate you for your code, this is very helpfull and I've been searching for something like it for quite some time.
I wanted to use it to capture the CS:GO skins market but when i tried to run your code it kept getting request errors after 2 or more hours of the code running so I decided to try to fix it.
I did a workarround with the request part by adding a try/except to avoid stopping the execution of the program and it worked fine but the program would still take at least 12 hours to run so i implemented threading to parallelize the requests and make it more time efficient.
This is by no means perfect but I think it is a welcoming adition to your already amazing code.
Hope you find it usefull.

Copy link
Owner

@blakeporterneuro blakeporterneuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Luan,
This is great! Glad my code was a useful base. Thanks for helping to improve it.
Cheers,
Blake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants