-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes in story_image #186
Open
biswajit-synkrama
wants to merge
61
commits into
blackmann:master
Choose a base branch
from
Kashmira-Mayekar:biswa/minorChanges
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Minor changes in story_image #186
biswajit-synkrama
wants to merge
61
commits into
blackmann:master
from
Kashmira-Mayekar:biswa/minorChanges
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biswajit-synkrama
commented
May 21, 2024
- Change in story image common widget
- Change the version of the story view package
Support for HLS Video
Added Shimmer for Video and preloading story
Preloading issue
Remove Preloading
Added Shimmer and Blur background
# Conflicts: # lib/widgets/story_image.dart
Aditya/story reply
# Conflicts: # lib/controller/story_controller.dart # lib/widgets/story_view.dart
Aditya/story reply
geekpius
reviewed
Jul 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please I can't merge this request. You have too many files touched. You can close this PR and break your PR into multiple PRs in order of significant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.