refactor: define property and not set it

blacha · Aug 22, 2024 · 42c7059 · 42c7059
1 parent f31489a
commit 42c7059
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/packages/source-aws/src/__test__/source.aws.test.ts b/packages/source-aws/src/__test__/source.aws.test.ts
@@ -9,7 +9,9 @@ describe('SourceAwsS3', () => {
   });
 
   it('should not expose "client" for logging', () => {
-    const keys = Object.keys(new SourceAwsS3('s3://foo/bar.txt'));
+    const source = new SourceAwsS3('s3://foo/bar.txt');
+    const keys = Object.keys(source);
     assert.equal(keys.includes('client'), false);
+    assert.notEqual(source.client.config, null);
   });
 });
diff --git a/packages/source-aws/src/index.ts b/packages/source-aws/src/index.ts
@@ -51,13 +51,9 @@ export class SourceAwsS3 implements Source {
 
   constructor(url: URL | string, client: S3Client = new S3Client({})) {
     this.url = typeof url === 'string' ? new URL(url) : url;
-    // Make typescript happy
+    // S3 clients are very large and if this object gets logged the log is very very large
+    Object.defineProperty(this, 'client', { enumerable: false });
     this.client = client;
-    // S3 clients are very large and if this object gets logged the client is very very large
-    Object.defineProperty(this, 'client', {
-      enumerable: false,
-      value: client,
-    });
   }
 
   _head?: Promise<SourceMetadata>;