Fix random, erroneous D binding type generation; add missing IDL defaults #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern "func.cppinline and not func.conly" is to make sure that C bindings for `bgfx_vertex_layout_has` are still generated.
Non-deterministic ordering of hash-maps were the culprit all along!
jay3d
pushed a commit
to jay3d/bgfx
that referenced
this pull request
Dec 7, 2023
…ults (bkaradzic#3210) * Reformatted comments; fixed a couple of oversights * D bindings: deterministic sub-struct order * Added missing default to IDL * Fixed sub-struct linkage; regenerate D binds * Culled D bindings for header-only C++ functions * Added missing default to bgfx.idl * cppinline now supported by all auto-gen bindings The pattern "func.cppinline and not func.conly" is to make sure that C bindings for `bgfx_vertex_layout_has` are still generated. * Fix mangling issue; use updated BindBC-Common API * Add missing default to setTransform in IDL * Fix erroneous generation of `uc_int64` Non-deterministic ordering of hash-maps were the culprit all along! * Add missing default to overrideInternal IDL & re-generate
mipek
pushed a commit
to mipek/bgfx
that referenced
this pull request
Mar 2, 2024
…ults (bkaradzic#3210) * Reformatted comments; fixed a couple of oversights * D bindings: deterministic sub-struct order * Added missing default to IDL * Fixed sub-struct linkage; regenerate D binds * Culled D bindings for header-only C++ functions * Added missing default to bgfx.idl * cppinline now supported by all auto-gen bindings The pattern "func.cppinline and not func.conly" is to make sure that C bindings for `bgfx_vertex_layout_has` are still generated. * Fix mangling issue; use updated BindBC-Common API * Add missing default to setTransform in IDL * Fix erroneous generation of `uc_int64` Non-deterministic ordering of hash-maps were the culprit all along! * Add missing default to overrideInternal IDL & re-generate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c_uint64being generated asuc_int64at random, due to non-deterministic hash-map iteration ordering in Lua.bgfx.idl.bgfx.idl.