Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pyvista min pin #622

Merged
merged 1 commit into from
Jan 7, 2024
Merged

bump pyvista min pin #622

merged 1 commit into from
Jan 7, 2024

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Jan 7, 2024

🚀 Pull Request

Description

This pull-request bumps the minimum pin for pyvista, which on main (74142c4) is currently restricted to pyvista >=0.40,<0.42.2 due to a breaking behaviour in pyvista=0.42.2, see #447 for details.

There is now a geovista fix that will resolve #447, thus allowing geovista to use the latest version of pyvista. This fix is forthcoming and will result in the 0.4.1 patch release from the 0.4.x release feature branch.

Before the 0.4.1 patch can be released, we require to update the lock dependencies, apply the fix and deal with new deprecation's being issued from the latest version of pyvista.

Note

The docs are not yet building for 0.4.x.
The work to bootstrap the docs happened on main post 0.4.0 and the 0.4.x release branch.
i.e., it's okay to merge this pull-request with the failing CI RTD job, as I forgot to disable auto-doc building for PRs on RTDs.


@github-actions github-actions bot added the type: dependencies Auto-labelled label Jan 7, 2024
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86ec52f) 86.23% compared to head (df2e2a6) 86.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           v0.4.x     #622   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files          66       66           
  Lines        3617     3617           
=======================================
  Hits         3119     3119           
  Misses        498      498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle closed this Jan 7, 2024
@bjlittle bjlittle reopened this Jan 7, 2024
@bjlittle bjlittle changed the title unpin pyvista bump pyvista min pin Jan 7, 2024
@bjlittle bjlittle merged commit 86f5f3e into v0.4.x Jan 7, 2024
32 of 33 checks passed
@bjlittle bjlittle deleted the min-pin-pyvista branch January 7, 2024 22:16
@bjlittle bjlittle mentioned this pull request Jan 10, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependencies Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant