Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_modules convenience #541

Merged
merged 1 commit into from
Nov 29, 2023
Merged

add get_modules convenience #541

merged 1 commit into from
Nov 29, 2023

Conversation

bjlittle
Copy link
Owner

🚀 Pull Request

Description

This pull-request adds a geovista.common utility to recursively discover the (dot notation) modules belonging to a (dot notation) package.

Initial application targets example script discovery in geovista.cli, and support for image testing of example scripts.


@github-actions github-actions bot added the type: testing Auto-labelled label Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d449616) 94.85% compared to head (2d81f7f) 94.86%.

Files Patch % Lines
src/geovista/common.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #541   +/-   ##
=======================================
  Coverage   94.85%   94.86%           
=======================================
  Files         116      117    +1     
  Lines        4701     4728   +27     
=======================================
+ Hits         4459     4485   +26     
- Misses        242      243    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle merged commit a84b2b4 into main Nov 29, 2023
16 checks passed
@bjlittle bjlittle deleted the common-get-modules branch November 29, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: testing Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant