Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10317] - Claimed Domain Notification Email #5248

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Jan 10, 2025

🎟️ Tracking

PM-10317

📔 Objective

Making changes to the email template for sending emails to users with domains matching the one claimed by the org.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jrmccannon jrmccannon requested a review from a team as a code owner January 10, 2025 17:10
@jrmccannon jrmccannon requested a review from BTreston January 10, 2025 17:10
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.96%. Comparing base (45d2c53) to head (26efd2e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../Services/Implementations/HandlebarsMailService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5248   +/-   ##
=======================================
  Coverage   43.96%   43.96%           
=======================================
  Files        1476     1476           
  Lines       68250    68250           
  Branches     6171     6171           
=======================================
  Hits        30007    30007           
  Misses      36936    36936           
  Partials     1307     1307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsfe9d8217-b392-4af0-a80d-fe570a8257a6

No New Or Fixed Issues Found

@vincentsalucci vincentsalucci merged commit 730f83b into main Jan 10, 2025
53 checks passed
@vincentsalucci vincentsalucci deleted the jmccannon/ac/pm-10317-email-revisions branch January 10, 2025 20:19
@vincentsalucci
Copy link
Member

Merged on behalf of @jrmccannon's internet issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants