Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11730] Remove feature flag: AC-2476-deprecate-stripe-sources-api #5201

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11730

📔 Objective

Removes the Stripe Sources API Deprecation feature flag.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
Remove Integration with Stripe's Sources API AC-2476-deprecate-stripe-sources-api ✅ all references removed

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.46%. Comparing base (83404ef) to head (bff3e15).

Files with missing lines Patch % Lines
src/Core/Services/Implementations/UserService.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5201      +/-   ##
==========================================
+ Coverage   43.33%   43.46%   +0.12%     
==========================================
  Files        1458     1458              
  Lines       66491    66443      -48     
  Branches     6078     6069       -9     
==========================================
+ Hits        28817    28882      +65     
+ Misses      36383    36270     -113     
  Partials     1291     1291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 30, 2024

Logo
Checkmarx One – Scan Summary & Details51260543-78ac-4ea4-8bb0-2dd139aabe9c

No New Or Fixed Issues Found

@jrmccannon jrmccannon removed their request for review January 3, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants