[PM-11502] Support Remember Email option when using SSO authentication #13391
+312
−334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trmartin4
changed the base branch from
main
to
auth/pm-17751/remember-sso-email
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## auth/pm-17751/remember-sso-email #13391 +/- ##
=================================================================
Coverage 35.21% 35.22%
=================================================================
Files 3126 3126
Lines 92540 92507 -33
Branches 16854 16845 -9
=================================================================
- Hits 32586 32581 -5
+ Misses 57496 57469 -27
+ Partials 2458 2457 -1 ☔ View full report in Codecov by Sentry. |
|
|
New Issues (4)Checkmarx found the following issues in this Pull Request
Fixed Issues (536)Great job! The following issues were fixed in this Pull Request
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11502
📔 Objective
The Remember Email option was not working correctly when using SSO authentication.
Previously, the Remember Email choice only took effect after authentication was complete. This necessitated a lot of extra code and complexity in the
LoginEmailServicein order to track the user's email, as well as whether they want to remember it (but don't remember it yet!) through the various authentication flows. The reason SSO didn't work is because that particular flow didn't handle it correctly after login.Rather than build on that complexity, this PR changes the underlying assumption of when the Remember Email choice takes affect. The Remember Email option now takes effect as soon as you perform some action on the Login screen. This adjustment has been verified as acceptable by Product. The choice to remember email now takes effect when:
This allowed the simplification of the
LoginEmailServiceinterface quite a bit. TheLoginEmailServicenow has two pieces of state it manages:loginEmailsetLoginEmailand exposed via theloginEmail$observable.rememberedEmailnull.setRememberEmailChoicemethod and exposed via therememberedEmail$observable.📸 Screenshots
Web
Demonstrating that the remembered email persists through all operations, including SSO
web_remember_email_persists.mov
Desktop
Demonstrating that adding an account does not remember email, but logging in does
desktop_add_account_not_remembered.mov
Extension
Demonstrating that adding an account does not remember email, but logging in does
extension_not_remembered_account_add.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes