Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ac/pm 16953 bulk restore revoke dialog design discrepancies #13387

Merged

Conversation

BTreston
Copy link
Contributor

@BTreston BTreston commented Feb 13, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16953

📔 Objective

Fixes UI Design

📸 Screenshots

Screenshot 2025-02-13 at 11 29 31 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.32%. Comparing base (7984bb3) to head (765738f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13387       +/-   ##
===========================================
+ Coverage   15.76%   35.32%   +19.55%     
===========================================
  Files          27     3128     +3101     
  Lines        1884    92600    +90716     
  Branches        0    16826    +16826     
===========================================
+ Hits          297    32709    +32412     
- Misses       1587    57431    +55844     
- Partials        0     2460     +2460     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link
Contributor

github-actions bot commented Feb 13, 2025

Logo
Checkmarx One – Scan Summary & Detailsf9d798a4-ac35-4b53-bbc2-5c83b48f5135

New Issues (4)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2025-0995 Npm-electron-34.0.0 Vulnerable Package
HIGH CVE-2025-0996 Npm-electron-34.0.0 Vulnerable Package
HIGH CVE-2025-0997 Npm-electron-34.0.0 Vulnerable Package
HIGH CVE-2025-0998 Npm-electron-34.0.0 Vulnerable Package

@BTreston BTreston marked this pull request as ready for review February 13, 2025 16:37
@BTreston BTreston requested a review from a team as a code owner February 13, 2025 16:37
@BTreston BTreston requested a review from r-tome February 13, 2025 16:37
@BTreston BTreston merged commit 86ce9d3 into main Feb 13, 2025
50 checks passed
@BTreston BTreston deleted the ac/pm-16953-Bulk-Restore-Revoke-Dialog-design-discrepancies branch February 13, 2025 19:43
jprusik pushed a commit to jprusik/clients that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants