-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14426] At-risk password Getting Started Carousel #13383
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13383 +/- ##
=======================================
Coverage 35.33% 35.34%
=======================================
Files 3129 3132 +3
Lines 92579 92635 +56
Branches 16807 16813 +6
=======================================
+ Hits 32713 32738 +25
- Misses 57427 57458 +31
Partials 2439 2439 ☔ View full report in Codecov by Sentry. |
<ng-content select="[bitDialogIcon]"></ng-content> | ||
} @else { | ||
<i class="bwi bwi-exclamation-triangle tw-text-3xl tw-text-warning" aria-hidden="true"></i> | ||
@if (!hideIcon()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ I needed a means to hide the icon in the simple dialog as seen in the Figma.
I tried the normal bit-dialog
, but it also always has a header/footer so I found it easier to hide the icon here instead.
@bitwarden/team-ui-foundation Let me know if there's an alternative you'd prefer instead. Thanks!
Great job, no security vulnerabilities found in this Pull Request |
- Create a Carousel NgModule so that the carousel component and carousel slide component are exported - Update barrel files - Adjust min height calculation logic to wait for ;hidden slides to finish rendering before calculating height
…state definition for banner and carousel dismissal
fa88f95
to
eec3775
Compare
|
🎟️ Tracking
PM-14426
📔 Objective
Introduce the Getting Started Carousel dialog on the At-risk password page. The dialog is only dismissible after viewing the last slide, at which point the dialog will not be shown again.
📸 Screenshots
Screen.Recording.2025-02-12.at.12.09.20.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes