Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14426] At-risk password Getting Started Carousel #13383

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

shane-melton
Copy link
Member

@shane-melton shane-melton commented Feb 12, 2025

🎟️ Tracking

PM-14426

📔 Objective

Introduce the Getting Started Carousel dialog on the At-risk password page. The dialog is only dismissible after viewing the last slide, at which point the dialog will not be shown again.

📸 Screenshots

Screen.Recording.2025-02-12.at.12.09.20.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 65.67164% with 23 lines in your changes missing coverage. Please review.

Project coverage is 35.34%. Comparing base (f0dcc1a) to head (eec3775).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ault/src/components/dark-image-source.directive.ts 37.50% 10 Missing ⚠️
...rousel-dialog/at-risk-carousel-dialog.component.ts 64.28% 5 Missing ⚠️
...at-risk-passwords/at-risk-password-page.service.ts 33.33% 4 Missing ⚠️
.../src/dialog/simple-dialog/simple-dialog.stories.ts 0.00% 3 Missing ⚠️
...rc/dialog/simple-dialog/simple-dialog.component.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13383   +/-   ##
=======================================
  Coverage   35.33%   35.34%           
=======================================
  Files        3129     3132    +3     
  Lines       92579    92635   +56     
  Branches    16807    16813    +6     
=======================================
+ Hits        32713    32738   +25     
- Misses      57427    57458   +31     
  Partials     2439     2439           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

<ng-content select="[bitDialogIcon]"></ng-content>
} @else {
<i class="bwi bwi-exclamation-triangle tw-text-3xl tw-text-warning" aria-hidden="true"></i>
@if (!hideIcon()) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I needed a means to hide the icon in the simple dialog as seen in the Figma.

I tried the normal bit-dialog, but it also always has a header/footer so I found it easier to hide the icon here instead.

@bitwarden/team-ui-foundation Let me know if there's an alternative you'd prefer instead. Thanks!

Copy link
Contributor

github-actions bot commented Feb 12, 2025

Logo
Checkmarx One – Scan Summary & Details32810ddf-6085-4a6b-b07e-9ae80a85ea8f

Great job, no security vulnerabilities found in this Pull Request

@shane-melton shane-melton marked this pull request as ready for review February 13, 2025 00:07
@shane-melton shane-melton requested review from a team as code owners February 13, 2025 00:07
Base automatically changed from vault/pm-14419/change-password-url-service to main February 13, 2025 18:58
- Create a Carousel NgModule so that the carousel component and carousel slide component are exported
- Update barrel files
- Adjust min height calculation logic to wait for ;hidden slides to finish rendering before calculating height
…state definition for banner and carousel dismissal
@shane-melton shane-melton force-pushed the vault/pm-14426/at-risk-password-carousel branch from fa88f95 to eec3775 Compare February 13, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant