Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15613] fix incorrect route transitions #13316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented Feb 9, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15613

📔 Objective

Fix incorrect route transitions. The following should all fly in from the right:

  • cipher view -> attachments
  • cipher view -> password history
  • trash -> password history
  • More from Bitwarden -> Premium

📸 Screenshots

Screen.Recording.2025-02-08.at.7.06.08.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.32%. Comparing base (7984bb3) to head (ebb3182).

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13316       +/-   ##
===========================================
+ Coverage   15.76%   35.32%   +19.55%     
===========================================
  Files          27     3128     +3101     
  Lines        1884    92600    +90716     
  Branches        0    16826    +16826     
===========================================
+ Hits          297    32709    +32412     
- Misses       1587    57431    +55844     
- Partials        0     2460     +2460     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willmartian willmartian requested a review from vleague2 February 9, 2025 00:07
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Logo
Checkmarx One – Scan Summary & Detailsa0038236-4341-45dd-8f80-6292139fc8b4

New Issues (4)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2025-0995 Npm-electron-34.0.0 Vulnerable Package
HIGH CVE-2025-0996 Npm-electron-34.0.0 Vulnerable Package
HIGH CVE-2025-0997 Npm-electron-34.0.0 Vulnerable Package
HIGH CVE-2025-0998 Npm-electron-34.0.0 Vulnerable Package

Copy link
Contributor

@vleague2 vleague2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a design review for this?

@willmartian
Copy link
Contributor Author

cc @danielleflinn, can you look at this when you are back in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants