-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15613] fix incorrect route transitions #13316
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13316 +/- ##
===========================================
+ Coverage 15.76% 35.32% +19.55%
===========================================
Files 27 3128 +3101
Lines 1884 92600 +90716
Branches 0 16826 +16826
===========================================
+ Hits 297 32709 +32412
- Misses 1587 57431 +55844
- Partials 0 2460 +2460 ☔ View full report in Codecov by Sentry. |
New Issues (4)Checkmarx found the following issues in this Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a design review for this?
cc @danielleflinn, can you look at this when you are back in? |
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15613
📔 Objective
Fix incorrect route transitions. The following should all fly in from the right:
📸 Screenshots
Screen.Recording.2025-02-08.at.7.06.08.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes