Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17198
📔 Objective
This gets Opera ready for MV3, it adds opera entries into the
manifest.v3.json
file so that the sidebar is available. Currently the ability to set the sidebar icon is broken so we are skipping that for now. The badge number is still working fine though. We just won't get the gray icon or the blue plus locked icon. Those icons still work fine for the popup action though.📸 Screenshots
Logged out:
![Screenshot 2025-01-31 at 2 59 30 PM](https://private-user-images.githubusercontent.com/19896123/408712518-c710aab1-e6d4-43b7-b77a-cb2c59285c34.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTY5NTYsIm5iZiI6MTczOTI1NjY1NiwicGF0aCI6Ii8xOTg5NjEyMy80MDg3MTI1MTgtYzcxMGFhYjEtZTZkNC00M2I3LWI3N2EtY2IyYzU5Mjg1YzM0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA2NTA1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY0MGEyMmMyNzViMjRjZTA4MjQyMzIxNmYzYWM0ODliYjgwZjU3ZmM2YWRjNDQwOGZjZjFmNTg4YjZhMDkzZTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.glGN1zPhTbdW455EkxsNAumc6lnitTs80ZVJ1bf2hcY)
Unlocked with ciphers for page:
![Screenshot 2025-01-31 at 3 00 01 PM](https://private-user-images.githubusercontent.com/19896123/408712616-aefa119e-9021-4048-9a0b-cb1a8aa01367.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTY5NTYsIm5iZiI6MTczOTI1NjY1NiwicGF0aCI6Ii8xOTg5NjEyMy80MDg3MTI2MTYtYWVmYTExOWUtOTAyMS00MDQ4LTlhMGItY2IxYThhYTAxMzY3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA2NTA1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJhYjZmNmQ1NGFiMThkMmYwMWIwMTU0OTVhMjBkMzYyNjIxZTg4YzY1YWFkZTJiNTEyMDc4ZmUwYzQ1OGZkYjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9RI6MAtPeQV6AUO-PjHBlCRFS8r0KKCcAuwslqiLEJk)
Locked:
![Screenshot 2025-01-31 at 3 00 13 PM](https://private-user-images.githubusercontent.com/19896123/408712710-f3bd1d10-6637-46d7-ba4a-50deac0dc022.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTY5NTYsIm5iZiI6MTczOTI1NjY1NiwicGF0aCI6Ii8xOTg5NjEyMy80MDg3MTI3MTAtZjNiZDFkMTAtNjYzNy00NmQ3LWJhNGEtNTBkZWFjMGRjMDIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA2NTA1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUwNzU4NmNiODVlNWU2NzU2ZTRhMmI1YzA1NmU2NWJmYjlhYWViMjlkMDBlYTRjYzFiYzViYWJhYzNmYmEzNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qKzEdSNRghWURcfKaNODLFRPo-NfxpnXTNw379bd3ds)
Unlocked with no ciphers for page:
![Screenshot 2025-01-31 at 3 00 41 PM](https://private-user-images.githubusercontent.com/19896123/408712765-60cb3cb7-021b-484d-9990-355586a95a1e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTY5NTYsIm5iZiI6MTczOTI1NjY1NiwicGF0aCI6Ii8xOTg5NjEyMy80MDg3MTI3NjUtNjBjYjNjYjctMDIxYi00ODRkLTk5OTAtMzU1NTg2YTk1YTFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA2NTA1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA2N2U2MzY1YjM3NmQwZDQwZDE3YTNiOWM0M2ZjOWFhODJmMTQxOGVmMTAwNDQ1MTBiMDNmZDdiY2Q5ZTI3YjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.-mdragfc9R7avrtwUX4nYWKwYthoqNjjWrjAoSoNTHQ)
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes