Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Opera Ready for MV3 #13190

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Get Opera Ready for MV3 #13190

wants to merge 4 commits into from

Conversation

justindbaur
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17198

📔 Objective

This gets Opera ready for MV3, it adds opera entries into the manifest.v3.json file so that the sidebar is available. Currently the ability to set the sidebar icon is broken so we are skipping that for now. The badge number is still working fine though. We just won't get the gray icon or the blue plus locked icon. Those icons still work fine for the popup action though.

📸 Screenshots

Logged out:
Screenshot 2025-01-31 at 2 59 30 PM

Unlocked with ciphers for page:
Screenshot 2025-01-31 at 3 00 01 PM

Locked:
Screenshot 2025-01-31 at 3 00 13 PM

Unlocked with no ciphers for page:
Screenshot 2025-01-31 at 3 00 41 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@justindbaur justindbaur requested a review from a team as a code owner January 31, 2025 20:02
@justindbaur justindbaur marked this pull request as draft January 31, 2025 20:02
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Logo
Checkmarx One – Scan Summary & Details23782d79-e06d-4c50-a85e-eee93f6fb755

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 35.20%. Comparing base (543cf0f) to head (09bbb90).

Files with missing lines Patch % Lines
apps/browser/src/platform/browser/browser-api.ts 0.00% 5 Missing ⚠️
...pps/browser/src/platform/listeners/update-badge.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13190      +/-   ##
==========================================
- Coverage   35.20%   35.20%   -0.01%     
==========================================
  Files        3126     3126              
  Lines       92563    92567       +4     
  Branches    16857    16859       +2     
==========================================
  Hits        32590    32590              
- Misses      57516    57520       +4     
  Partials     2457     2457              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justindbaur justindbaur marked this pull request as ready for review February 3, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant