[PM-16937] Remove Billing Circular Dependency

[cturnbull-bitwarden]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16937

📔 Objective

Removed Billing's dependence on components to resolve a circular dependency

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – d2473595-c67c-4380-b244-be1cacd822b7

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	Client_DOM_Open_Redirect	/apps/web/src/app/billing/organizations/payment-method/organization-payment-method.component.ts: 158	details The potentially tainted value provided by path in /apps/web/src/app/billing/organizations/payment-method/organization-payment-method.component.ts a... Attack Vector

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	Client_DOM_Open_Redirect	/apps/web/src/app/billing/organizations/payment-method/organization-payment-method.component.ts: 155

[codecov]

Codecov Report

Attention: Patch coverage is 12.29508% with 107 lines in your changes missing coverage. Please review.

Project coverage is 35.21%. Comparing base (2b5c786) to head (123a464).

Files with missing lines	Patch %	Lines
...nts/manage-client-subscription-dialog.component.ts	0.00%	23 Missing ⚠️
...nt-method/organization-payment-method.component.ts	0.00%	22 Missing ⚠️
...rs/subscription/provider-subscription.component.ts	0.00%	12 Missing ⚠️
...ling-history/provider-billing-history.component.ts	0.00%	10 Missing ⚠️
...ling/providers/clients/manage-clients.component.ts	0.00%	9 Missing ⚠️
.../src/app/vault/individual-vault/vault.component.ts	0.00%	7 Missing ⚠️
...pps/web/src/app/vault/org-vault/vault.component.ts	0.00%	7 Missing ⚠️
...ling/organizations/change-plan-dialog.component.ts	14.28%	6 Missing ⚠️
...app/secrets-manager/overview/overview.component.ts	0.00%	5 Missing ⚠️
...common/src/billing/services/billing-api.service.ts	0.00%	5 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13085      +/-   ##
==========================================
- Coverage   35.21%   35.21%   -0.01%     
==========================================
  Files        3126     3127       +1     
  Lines       92540    92587      +47     
  Branches    16854    16864      +10     
==========================================
+ Hits        32589    32604      +15     
- Misses      57494    57524      +30     
- Partials     2457     2459       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amorask-bitwarden]

Billing changes look good.

[Hinton]

Tsconfig changes looks good. I'm no longer part of platform-dev though.

[shane-melton]

Vault change looks good!

[coroiu]

Gonna trust Oscar on the tsconfig.json review here :)

[coroiu]

Added some suggestions for better aligning test naming with conventions, but I'm classifying them as non-blocking since I'm technically only reviewing platform code :)

Feel free to follow up in a separate PR to avoid multi-team reviews!